Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting #1854

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Fix linting #1854

merged 1 commit into from
Sep 16, 2017

Conversation

Hypnosphi
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 16, 2017 •
edited
Loading

Codecov Report

Merging #1854 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1854   +/-   ##
=======================================
  Coverage   21.33%   21.33%           
=======================================
  Files         257      257           
  Lines        5737     5737           
  Branches      695      691    -4     
=======================================
  Hits         1224     1224           
+ Misses       3977     3975    -2     
- Partials      536      538    +2
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <100%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb83c7...b786d61. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team September 16, 2017 19:31
ndelangen
ndelangen approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already fixed on release/3.3

@ndelangen ndelangen merged commit 05edc3e into master Sep 16, 2017
@ndelangen ndelangen deleted the fix-lint branch September 16, 2017 20:03
@dependencies dependencies bot mentioned this pull request Feb 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypnosphi @ndelangen